Skip to content

HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.#1315

Merged
bharatviswa504 merged 3 commits intoapache:trunkfrom
bharatviswa504:HDDS-1975
Aug 26, 2019
Merged

HDDS-1975. Implement default acls for bucket/volume/key for OM HA code.#1315
bharatviswa504 merged 3 commits intoapache:trunkfrom
bharatviswa504:HDDS-1975

Conversation

@bharatviswa504
Copy link
Contributor

@bharatviswa504 bharatviswa504 commented Aug 19, 2019

No description provided.

@bharatviswa504 bharatviswa504 requested a review from arp7 August 19, 2019 20:37
@bharatviswa504 bharatviswa504 self-assigned this Aug 19, 2019
@bharatviswa504
Copy link
Contributor Author

bharatviswa504 commented Aug 19, 2019

/retest

@arp7 arp7 requested a review from xiaoyuyao August 19, 2019 21:45
@hadoop-yetus
Copy link

hadoop-yetus commented Aug 19, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 149 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 44 Maven dependency ordering for branch
+1 mvninstall 773 trunk passed
+1 compile 473 trunk passed
+1 checkstyle 85 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1052 branch has no errors when building and testing our client artifacts.
+1 javadoc 172 trunk passed
0 spotbugs 486 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 707 trunk passed
_ Patch Compile Tests _
0 mvndep 24 Maven dependency ordering for patch
-1 mvninstall 138 hadoop-ozone in the patch failed.
-1 compile 55 hadoop-ozone in the patch failed.
-1 javac 55 hadoop-ozone in the patch failed.
-0 checkstyle 25 The patch fails to run checkstyle in hadoop-ozone
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 735 patch has no errors when building and testing our client artifacts.
-1 javadoc 53 hadoop-ozone in the patch failed.
-1 findbugs 105 hadoop-ozone in the patch failed.
_ Other Tests _
+1 unit 358 hadoop-hdds in the patch passed.
-1 unit 107 hadoop-ozone in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
5816
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/Dockerfile
GITHUB PR #1315
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2a93514f426d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 4f925af
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1315/out/maven-patch-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/testReport/
Max. process+thread count 390 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 20, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 1143 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 30 Maven dependency ordering for branch
+1 mvninstall 630 trunk passed
+1 compile 388 trunk passed
+1 checkstyle 71 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 968 branch has no errors when building and testing our client artifacts.
+1 javadoc 173 trunk passed
0 spotbugs 458 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 678 trunk passed
_ Patch Compile Tests _
0 mvndep 20 Maven dependency ordering for patch
+1 mvninstall 585 the patch passed
+1 compile 399 the patch passed
+1 javac 399 the patch passed
+1 checkstyle 90 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 758 patch has no errors when building and testing our client artifacts.
+1 javadoc 176 the patch passed
+1 findbugs 708 the patch passed
_ Other Tests _
+1 unit 379 hadoop-hdds in the patch passed.
-1 unit 333 hadoop-ozone in the patch failed.
+1 asflicense 56 The patch does not generate ASF License warnings.
7750
Reason Tests
Failed junit tests hadoop.ozone.om.request.s3.bucket.TestS3BucketCreateRequest
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/3/artifact/out/Dockerfile
GITHUB PR #1315
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a9c39b494fac 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 4f925af
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/3/testReport/
Max. process+thread count 1325 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor Author

bharatviswa504 commented Aug 20, 2019

/retest

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 20, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 543 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 33 Maven dependency ordering for branch
+1 mvninstall 603 trunk passed
+1 compile 356 trunk passed
+1 checkstyle 64 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 804 branch has no errors when building and testing our client artifacts.
+1 javadoc 150 trunk passed
0 spotbugs 415 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 604 trunk passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 546 the patch passed
+1 compile 355 the patch passed
+1 javac 355 the patch passed
+1 checkstyle 62 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 654 patch has no errors when building and testing our client artifacts.
+1 javadoc 159 the patch passed
+1 findbugs 692 the patch passed
_ Other Tests _
+1 unit 303 hadoop-hdds in the patch passed.
-1 unit 3363 hadoop-ozone in the patch failed.
+1 asflicense 42 The patch does not generate ASF License warnings.
9491
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestContainerStateMachineFailures
hadoop.ozone.client.rpc.TestKeyInputStream
hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.client.rpc.Test2WayCommitInRatis
hadoop.ozone.client.rpc.TestReadRetries
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
hadoop.ozone.client.rpc.TestFailureHandlingByClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/4/artifact/out/Dockerfile
GITHUB PR #1315
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ed82037be8b1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 4f925af
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/4/testReport/
Max. process+thread count 3855 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 20, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 97 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 28 Maven dependency ordering for branch
+1 mvninstall 638 trunk passed
+1 compile 386 trunk passed
+1 checkstyle 68 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 955 branch has no errors when building and testing our client artifacts.
+1 javadoc 171 trunk passed
0 spotbugs 457 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 675 trunk passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 586 the patch passed
+1 compile 399 the patch passed
+1 javac 399 the patch passed
+1 checkstyle 79 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 752 patch has no errors when building and testing our client artifacts.
+1 javadoc 166 the patch passed
+1 findbugs 708 the patch passed
_ Other Tests _
-1 unit 353 hadoop-hdds in the patch failed.
-1 unit 2362 hadoop-ozone in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
8646
Reason Tests
Failed junit tests hadoop.hdds.scm.block.TestBlockManager
hadoop.ozone.scm.node.TestQueryNode
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.container.server.TestSecureContainerServer
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/artifact/out/Dockerfile
GITHUB PR #1315
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e6d421fe112b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6244502
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/testReport/
Max. process+thread count 5299 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor Author

bharatviswa504 commented Aug 22, 2019 •
edited
Loading

Updated and rebased the patch as now HDDS-1927 got checked in.
It is ready for review.

@xiaoyuyao @arp7

@bharatviswa504
Copy link
Contributor Author

bharatviswa504 commented Aug 22, 2019

/retest

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 23, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 82 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 652 trunk passed
+1 compile 417 trunk passed
+1 checkstyle 79 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 970 branch has no errors when building and testing our client artifacts.
+1 javadoc 174 trunk passed
0 spotbugs 465 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 680 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 588 the patch passed
+1 compile 417 the patch passed
+1 javac 417 the patch passed
+1 checkstyle 89 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 882 patch has no errors when building and testing our client artifacts.
+1 javadoc 231 the patch passed
+1 findbugs 818 the patch passed
_ Other Tests _
+1 unit 424 hadoop-hdds in the patch passed.
-1 unit 3528 hadoop-ozone in the patch failed.
+1 asflicense 65 The patch does not generate ASF License warnings.
10322
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
hadoop.hdds.scm.pipeline.TestPipelineClose
hadoop.ozone.om.TestScmSafeMode
hadoop.ozone.container.server.TestSecureContainerServer
hadoop.ozone.client.rpc.Test2WayCommitInRatis
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
hadoop.ozone.client.rpc.TestReadRetries
hadoop.ozone.om.TestOzoneManager
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/10/artifact/out/Dockerfile
GITHUB PR #1315
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 61def168f189 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 93daf69
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/10/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/10/testReport/
Max. process+thread count 4420 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/10/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao
xiaoyuyao reviewed Aug 23, 2019
View reviewed changes
Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. A few comments added inline.

@bharatviswa504
Copy link
Contributor Author

bharatviswa504 commented Aug 23, 2019

Thank You @xiaoyuyao for the review.
I have addressed review comments.

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 24, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 43 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 29 Maven dependency ordering for branch
+1 mvninstall 618 trunk passed
+1 compile 376 trunk passed
+1 checkstyle 70 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 846 branch has no errors when building and testing our client artifacts.
+1 javadoc 162 trunk passed
0 spotbugs 445 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 644 trunk passed
_ Patch Compile Tests _
0 mvndep 20 Maven dependency ordering for patch
+1 mvninstall 574 the patch passed
+1 compile 368 the patch passed
+1 javac 368 the patch passed
+1 checkstyle 72 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 664 patch has no errors when building and testing our client artifacts.
+1 javadoc 154 the patch passed
+1 findbugs 657 the patch passed
_ Other Tests _
+1 unit 289 hadoop-hdds in the patch passed.
-1 unit 1984 hadoop-ozone in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
7758
Reason Tests
Failed junit tests hadoop.ozone.container.server.TestSecureContainerServer
hadoop.ozone.client.rpc.TestWatchForCommit
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/11/artifact/out/Dockerfile
GITHUB PR #1315
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9b0c75acbd59 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d2225c8
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/11/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/11/testReport/
Max. process+thread count 5101 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1315/11/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xiaoyuyao
Copy link
Contributor

xiaoyuyao commented Aug 26, 2019

+1, Thanks @bharatviswa504 for the update.

@bharatviswa504
Copy link
Contributor Author

bharatviswa504 commented Aug 26, 2019

Thank You @xiaoyuyao for the review.
I will commit this to the trunk.

@bharatviswa504 bharatviswa504 merged commit d1aa859 into apache:trunk Aug 26, 2019
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
@bharatviswa504
HDDS-1975. Implement default acls for bucket/volume/key for OM HA cod…
3a9412e 
…e. (apache#1315)
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
@bharatviswa504 @RogPodge
HDDS-1975. Implement default acls for bucket/volume/key for OM HA cod…
aedb111 
…e. (apache#1315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoyuyao xiaoyuyao xiaoyuyao left review comments

@arp7 arp7 Awaiting requested review from arp7

Assignees

@bharatviswa504 bharatviswa504

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bharatviswa504 @hadoop-yetus @xiaoyuyao